Add pytests for featurize_directory and featurize_files #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JesseMckinzie
commented
Jan 5, 2024
JesseMckinzie
commented
- Add pytests for featurize_directory and featurize_files
- Add tissuenet data for tests
Apply Sweep Rules to your PR?
|
sameeul
reviewed
Jan 11, 2024
tests/python/test_tissuenet_data.py
Outdated
|
|
||
| tissuenet_int = np.array([int_p0_y1_r1_c0, int_p0_y1_r1_c1]) | ||
| tissuenet_seg = np.array([seg_p0_y1_r1_c0, seg_p0_y1_r1_c1]) | ||
| print(tissuenet_int) |
tests/python/test_nyxus.py
Outdated
| files_not_equal.append(col) | ||
| break | ||
|
|
||
| print(files_not_equal) |
There was a problem hiding this comment.
I think we can remove print. If necessary, we can modify the assert to print a custom message when it fails, something like this:
assert len(files_not_equal) == 0, f"Files that are not equal:\n {files_not_equal}"
sameeul
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.